Re: [RFC 01/18] drm/amdgpu: Use DRM scheduler API in amdgpu_xcp_release_sched

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/01/2025 12:30, Christian König wrote:
Am 08.01.25 um 19:35 schrieb Tvrtko Ursulin:
Lets use the existing helper instead of peeking into the structure
directly.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx>
Cc: Christian König <christian.koenig@xxxxxxx>
Cc: Danilo Krummrich <dakr@xxxxxxxxxx>
Cc: Matthew Brost <matthew.brost@xxxxxxxxx>
Cc: Philipp Stanner <pstanner@xxxxxxxxxx>

Grr, I can't count of how many of those I already fixed :(

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

Thanks!

+ Alex

I forgot to cc amd-gfx for this one. Can you take it from here or I can send it standalone?

Regards,

Tvrtko


---
  drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c
index e209b5e101df..23b6f7a4aa4a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c
@@ -427,7 +427,7 @@ void amdgpu_xcp_release_sched(struct amdgpu_device *adev,
          return;
      sched = entity->entity.rq->sched;
-    if (sched->ready) {
+    if (drm_sched_wqueue_ready(sched)) {
          ring = to_amdgpu_ring(entity->entity.rq->sched);
          atomic_dec(&adev->xcp_mgr->xcp[ring->xcp_id].ref_cnt);
      }




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux