Re: [PATCH v2 3/3] drm/mxsfb: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

[Marek Vasut <marex@xxxxxxx>]

On 12/30/24 8:29 AM, Liu Ying wrote:

[...]

> > @@ -139,21 +140,35 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
> >   	if (!bridge)
> >   		return -ENODEV;
> >   
> > -	ret = drm_bridge_attach(&mxsfb->encoder, bridge, NULL, 0);
> > +	ret = drm_bridge_attach(&mxsfb->encoder, bridge, NULL,
> > +				DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> >   	if (ret)
> >   		return dev_err_probe(drm->dev, ret, "Failed to attach bridge\n");
> >   
> > -	mxsfb->bridge = bridge;
> > +	connector = drm_bridge_connector_init(drm, &mxsfb->encoder);
>
> Nit: Drop connector and use mxsfb->connector?
The code becomes too wide. The rest is fixed in V3.