On 12/13/2024 2:02 AM, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>
This driver fails to build in random configurations:
drivers/accel/amdxdna/amdxdna_mailbox.c:357:8: error: unknown type name 'irqreturn_t'
357 | static irqreturn_t mailbox_irq_handler(int irq, void *p)
| ^~~~~~~~~~~
drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_irq_handler':
drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: error: 'IRQ_HANDLED' undeclared (first use in this function)
367 | return IRQ_HANDLED;
| ^~~~~~~~~~~
drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: note: each undeclared identifier is reported only once for each function it appears in
drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_rx_worker':
drivers/accel/amdxdna/amdxdna_mailbox.c:395:25: error: implicit declaration of function 'disable_irq'; did you mean 'disable_work'? [-Wimplicit-function-declaration]
395 | disable_irq(mb_chann->msix_irq);
| ^~~~~~~~~~~
drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
121 | kfree(pt_node);
| ^~~~~
drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
153 | pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);
Include the headers that have the necessary declarations.
Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
amdxdna: includ linux/interrupt.h
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
The interrupt part of this is now fixed, see "accel/amdxdna: Add include
interrupt.h to amdxdna_mailbox.c".
The slab portion looks sane. I'll trim the patch when applying unless
you'd prefer something else.
Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
