From: Arnd Bergmann <arnd@xxxxxxxx> This driver fails to build in random configurations: drivers/accel/amdxdna/amdxdna_mailbox.c:357:8: error: unknown type name 'irqreturn_t' 357 | static irqreturn_t mailbox_irq_handler(int irq, void *p) | ^~~~~~~~~~~ drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_irq_handler': drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: error: 'IRQ_HANDLED' undeclared (first use in this function) 367 | return IRQ_HANDLED; | ^~~~~~~~~~~ drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: note: each undeclared identifier is reported only once for each function it appears in drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_rx_worker': drivers/accel/amdxdna/amdxdna_mailbox.c:395:25: error: implicit declaration of function 'disable_irq'; did you mean 'disable_work'? [-Wimplicit-function-declaration] 395 | disable_irq(mb_chann->msix_irq); | ^~~~~~~~~~~ drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node': drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration] 121 | kfree(pt_node); | ^~~~~ drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition': drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration] 153 | pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL); Include the headers that have the necessary declarations. Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver") Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> amdxdna: includ linux/interrupt.h Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> --- drivers/accel/amdxdna/aie2_solver.c | 1 + drivers/accel/amdxdna/amdxdna_mailbox.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/accel/amdxdna/aie2_solver.c b/drivers/accel/amdxdna/aie2_solver.c index a537c66589a4..0bbf91cad334 100644 --- a/drivers/accel/amdxdna/aie2_solver.c +++ b/drivers/accel/amdxdna/aie2_solver.c @@ -8,6 +8,7 @@ #include <drm/drm_print.h> #include <linux/bitops.h> #include <linux/bitmap.h> +#include <linux/slab.h> #include "aie2_solver.h" diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c index 415d99abaaa3..41bbc5796e11 100644 --- a/drivers/accel/amdxdna/amdxdna_mailbox.c +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c @@ -7,6 +7,7 @@ #include <drm/drm_managed.h> #include <linux/bitfield.h> #include <linux/iopoll.h> +#include <linux/interrupt.h> #define CREATE_TRACE_POINTS #include <trace/events/amdxdna.h> -- 2.39.5