Thanks Maíra!
Acked-by: Iago Toral Quiroga <itoral@xxxxxxxxxx>
El vie, 06-12-2024 a las 12:39 -0300, Maíra Canal escribió:
> This commit fixes several miscellaneous documentation errors. Mostly,
> delete/update comments that are outdated or are leftovers from past
> code
> changes. Apart from that, remove double-spaces in several comments.
>
> Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx>
> ---
> drivers/gpu/drm/v3d/v3d_bo.c | 4 ----
> drivers/gpu/drm/v3d/v3d_mmu.c | 8 ++++----
> drivers/gpu/drm/v3d/v3d_performance_counters.h | 12 +++++-------
> drivers/gpu/drm/v3d/v3d_sched.c | 12 ++++++------
> drivers/gpu/drm/v3d/v3d_submit.c | 9 +++++----
> 5 files changed, 20 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_bo.c
> b/drivers/gpu/drm/v3d/v3d_bo.c
> index 73ab7dd31b17..bb7815599435 100644
> --- a/drivers/gpu/drm/v3d/v3d_bo.c
> +++ b/drivers/gpu/drm/v3d/v3d_bo.c
> @@ -13,10 +13,6 @@
> * Display engines requiring physically contiguous allocations
> should
> * look into Mesa's "renderonly" support (as used by the Mesa pl111
> * driver) for an example of how to integrate with V3D.
> - *
> - * Long term, we should support evicting pages from the MMU when
> under
> - * memory pressure (thus the v3d_bo_get_pages() refcounting), but
> - * that's not a high priority since our systems tend to not have
> swap.
> */
>
> #include <linux/dma-buf.h>
> diff --git a/drivers/gpu/drm/v3d/v3d_mmu.c
> b/drivers/gpu/drm/v3d/v3d_mmu.c
> index 0f564fd7160c..a25d25a8ae61 100644
> --- a/drivers/gpu/drm/v3d/v3d_mmu.c
> +++ b/drivers/gpu/drm/v3d/v3d_mmu.c
> @@ -4,7 +4,7 @@
> /**
> * DOC: Broadcom V3D MMU
> *
> - * The V3D 3.x hardware (compared to VC4) now includes an MMU. It
> has
> + * The V3D 3.x hardware (compared to VC4) now includes an MMU. It
> has
> * a single level of page tables for the V3D's 4GB address space to
> * map to AXI bus addresses, thus it could need up to 4MB of
> * physically contiguous memory to store the PTEs.
> @@ -15,14 +15,14 @@
> *
> * To protect clients from each other, we should use the GMP to
> * quickly mask out (at 128kb granularity) what pages are available
> to
> - * each client. This is not yet implemented.
> + * each client. This is not yet implemented.
> */
>
> #include "v3d_drv.h"
> #include "v3d_regs.h"
>
> -/* Note: All PTEs for the 1MB superpage must be filled with the
> - * superpage bit set.
> +/* Note: All PTEs for the 64KB bigpage or 1MB superpage must be
> filled
> + * with the bigpage/superpage bit set.
> */
> #define V3D_PTE_SUPERPAGE BIT(31)
> #define V3D_PTE_BIGPAGE BIT(30)
> diff --git a/drivers/gpu/drm/v3d/v3d_performance_counters.h
> b/drivers/gpu/drm/v3d/v3d_performance_counters.h
> index d919a2fc9449..2bc4cce0744a 100644
> --- a/drivers/gpu/drm/v3d/v3d_performance_counters.h
> +++ b/drivers/gpu/drm/v3d/v3d_performance_counters.h
> @@ -2,11 +2,12 @@
> /*
> * Copyright (C) 2024 Raspberry Pi
> */
> +
> #ifndef V3D_PERFORMANCE_COUNTERS_H
> #define V3D_PERFORMANCE_COUNTERS_H
>
> -/* Holds a description of a given performance counter. The index of
> performance
> - * counter is given by the array on v3d_performance_counter.h
> +/* Holds a description of a given performance counter. The index of
> + * performance counter is given by the array on
> `v3d_performance_counter.c`.
> */
> struct v3d_perf_counter_desc {
> /* Category of the counter */
> @@ -20,15 +21,12 @@ struct v3d_perf_counter_desc {
> };
>
> struct v3d_perfmon_info {
> - /*
> - * Different revisions of V3D have different total number of
> + /* Different revisions of V3D have different total number of
> * performance counters.
> */
> unsigned int max_counters;
>
> - /*
> - * Array of counters valid for the platform.
> - */
> + /* Array of counters valid for the platform. */
> const struct v3d_perf_counter_desc *counters;
> };
>
> diff --git a/drivers/gpu/drm/v3d/v3d_sched.c
> b/drivers/gpu/drm/v3d/v3d_sched.c
> index a6c3760da6ed..da08ddb01d21 100644
> --- a/drivers/gpu/drm/v3d/v3d_sched.c
> +++ b/drivers/gpu/drm/v3d/v3d_sched.c
> @@ -5,16 +5,16 @@
> * DOC: Broadcom V3D scheduling
> *
> * The shared DRM GPU scheduler is used to coordinate submitting
> jobs
> - * to the hardware. Each DRM fd (roughly a client process) gets its
> - * own scheduler entity, which will process jobs in order. The GPU
> - * scheduler will round-robin between clients to submit the next
> job.
> + * to the hardware. Each DRM fd (roughly a client process) gets its
> + * own scheduler entity, which will process jobs in order. The GPU
> + * scheduler will schedule the clients with a FIFO scheduling
> algorithm.
> *
> * For simplicity, and in order to keep latency low for interactive
> * jobs when bulk background jobs are queued up, we submit a new job
> * to the HW only when it has completed the last one, instead of
> - * filling up the CT[01]Q FIFOs with jobs. Similarly, we use
> - * drm_sched_job_add_dependency() to manage the dependency between
> bin and
> - * render, instead of having the clients submit jobs using the HW's
> + * filling up the CT[01]Q FIFOs with jobs. Similarly, we use
> + * `drm_sched_job_add_dependency()` to manage the dependency between
> bin
> + * and render, instead of having the clients submit jobs using the
> HW's
> * semaphores to interlock between them.
> */
>
> diff --git a/drivers/gpu/drm/v3d/v3d_submit.c
> b/drivers/gpu/drm/v3d/v3d_submit.c
> index 9e439c9f0a93..4ff5de46fb22 100644
> --- a/drivers/gpu/drm/v3d/v3d_submit.c
> +++ b/drivers/gpu/drm/v3d/v3d_submit.c
> @@ -11,10 +11,11 @@
> #include "v3d_trace.h"
>
> /* Takes the reservation lock on all the BOs being referenced, so
> that
> - * at queue submit time we can update the reservations.
> + * we can attach fences and update the reservations after pushing
> the job
> + * to the queue.
> *
> * We don't lock the RCL the tile alloc/state BOs, or overflow
> memory
> - * (all of which are on exec->unref_list). They're entirely private
> + * (all of which are on render->unref_list). They're entirely
> private
> * to v3d, so we don't attach dma-buf fences to them.
> */
> static int
> @@ -55,11 +56,11 @@ v3d_lock_bo_reservations(struct v3d_job *job,
> * @bo_count: Number of GEM handles passed in
> *
> * The command validator needs to reference BOs by their index
> within
> - * the submitted job's BO list. This does the validation of the
> job's
> + * the submitted job's BO list. This does the validation of the
> job's
> * BO list and reference counting for the lifetime of the job.
> *
> * Note that this function doesn't need to unreference the BOs on
> - * failure, because that will happen at v3d_exec_cleanup() time.
> + * failure, because that will happen at `v3d_job_free()`.
> */
> static int
> v3d_lookup_bos(struct drm_device *dev,
