Hi Doug,
On Tue, 15 Oct 2024 09:06:04 -0700, Doug Anderson wrote:
> On Tue, Oct 15, 2024 at 4:46 AM Jean Delvare <jdelvare@xxxxxxx> wrote:
> > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> > is possible to test-build any driver which depends on OF on any
> > architecture by explicitly selecting OF. Therefore depending on
> > COMPILE_TEST as an alternative is no longer needed.
> >
> > To avoid reintroducing the randconfig bug originally fixed by commit
> > 876271118aa4 ("drm/display: Fix build error without CONFIG_OF"),
> > DRM_MSM which selects DRM_DISPLAY_DP_HELPER must explicitly depend
> > on OF. This is consistent with what all other DRM drivers are doing.
> >
> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> > Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > ---
> > For regular builds, this is a no-op, as OF is always enabled on
> > ARCH_QCOM and SOC_IMX5. So this change only affects test builds. As
> > explained before, allowing test builds only when OF is enabled
> > improves the quality of these test builds, as the result is then
> > closer to how the code is built on its intended targets.
> >
> > Changes in v3:
> > * Rebase on top of kernel v6.11.
> > Changes in v2:
> > * Let DRM_MSM depend on OF so that random test builds won't break.
> >
> > drivers/gpu/drm/display/Kconfig | 2 +-
> > drivers/gpu/drm/msm/Kconfig | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > --- linux-6.11.orig/drivers/gpu/drm/display/Kconfig
> > +++ linux-6.11/drivers/gpu/drm/display/Kconfig
> > @@ -3,7 +3,7 @@
> > config DRM_DISPLAY_DP_AUX_BUS
> > tristate
> > depends on DRM
> > - depends on OF || COMPILE_TEST
> > + depends on OF
> >
> > config DRM_DISPLAY_HELPER
> > tristate
> > --- linux-6.11.orig/drivers/gpu/drm/msm/Kconfig
> > +++ linux-6.11/drivers/gpu/drm/msm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_MSM
> > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
> > depends on COMMON_CLK
> > depends on IOMMU_SUPPORT
> > + depends on OF
>
> Perhaps nobody landed this because you're missing the msm maintainers
> as specified by `./scripts/get_maintainer.pl -f
> drivers/gpu/drm/msm/Kconfig` ? I've added them here. It seems like
> we'd at least need an Ack by those guys since this modified the
> msm/Kconfig...
You are right. The fix originally only touched
drivers/gpu/drm/display/Kconfig and I forgot to update the maintainers
list for v2 when drivers/gpu/drm/msm/Kconfig had to be modified as
well. Thank you for noticing and getting the right people involved,
this clearly made a difference :-)
> FWIW I haven't spent massive time studying this, but what you have
> here looks reasonable. I'm happy at least with this from a DP AUX bus
> perspective:
>
> Acked-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> Presumably landing this via drm-misc makes the most sense after MSM
> guys give it an Ack.
Thanks,
--
Jean Delvare
SUSE L3 Support
