Il 09/10/24 13:15, Shu-hsiang Yang ha scritto:
Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv modules. Key functionalities include data processing, V4L2 integration, resource management, debug support, and various control operations. Additionally, IRQ handling, platform device management, and MediaTek ISP DMA format support are also included. Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx> --- .../mediatek/isp/isp_7x/camsys/mtk_cam-raw.c | 5359 +++++++++++++++++ .../mediatek/isp/isp_7x/camsys/mtk_cam-raw.h | 325 + .../isp/isp_7x/camsys/mtk_cam-raw_debug.c | 403 ++ .../isp/isp_7x/camsys/mtk_cam-raw_debug.h | 39 + .../isp_7x/camsys/mtk_camera-v4l2-controls.h | 65 + 5 files changed, 6191 insertions(+) create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw_debug.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw_debug.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_camera-v4l2-controls.h diff --git a/drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.c b/drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.c new file mode 100644 index 000000000000..c025f53c952d --- /dev/null +++ b/drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.c @@ -0,0 +1,5359 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright (c) 2022 MediaTek Inc. + +#include <linux/clk.h> +#include <linux/interrupt.h> +#include <linux/iopoll.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/vmalloc.h> +#include <linux/videodev2.h> +#include <linux/suspend.h> +#include <linux/rtc.h> + +#include <media/v4l2-device.h> +#include <media/v4l2-event.h> +#include <media/v4l2-ioctl.h> +#include <media/v4l2-subdev.h> + +#include <soc/mediatek/smi.h> + +#include "mtk_cam.h" +#include "mtk_cam-feature.h" +#include "mtk_cam-raw.h" + +#include "mtk_cam-regs-mt8188.h" + +#include "mtk_cam-video.h" +#include "mtk_cam-seninf-if.h" +#include "mtk_camera-v4l2-controls.h" + +#include "mtk_cam-dmadbg.h" +#include "mtk_cam-raw_debug.h" + +static unsigned int debug_raw; +module_param(debug_raw, uint, 0644); +MODULE_PARM_DESC(debug_raw, "activates debug info"); + +static int debug_raw_num = -1; +module_param(debug_raw_num, int, 0644); +MODULE_PARM_DESC(debug_raw_num, "debug: num of used raw devices"); + +static int debug_pixel_mode = -1; +module_param(debug_pixel_mode, int, 0644); +MODULE_PARM_DESC(debug_pixel_mode, "debug: pixel mode"); + +static int debug_clk_idx = -1; +module_param(debug_clk_idx, int, 0644); +MODULE_PARM_DESC(debug_clk_idx, "debug: clk idx"); + +static int debug_dump_fbc; +module_param(debug_dump_fbc, int, 0644); +MODULE_PARM_DESC(debug_dump_fbc, "debug: dump fbc"); +
In addition to the first review that I gave you on patch [02/10]: please drop all those module parameters. If you want debug switches, use debugfs instead. Regards, Angelo
