-----Original Message----- From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: simona@xxxxxxxx; airlied@xxxxxxxxx; javierm@xxxxxxxxxx; jfalempe@xxxxxxxxxx Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx; Thomas Zimmermann <tzimmermann@xxxxxxx> Subject: [PATCH v3 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them > > Fbdev emulation for SHMEM and TTM requires helpers from the fbdev > subsystem. Select them from the modules that use them instead of the > core DRM module. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> LGTM. Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx> -Jonathan Cavitt > --- > drivers/gpu/drm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index db2e206a117c..88c4837d070c 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -11,7 +11,6 @@ menuconfig DRM > select DRM_PANEL_ORIENTATION_QUIRKS > select DRM_KMS_HELPER if DRM_FBDEV_EMULATION > select FB_CORE if DRM_FBDEV_EMULATION > - select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > select HDMI > select I2C > select DMA_SHARED_BUFFER > @@ -332,6 +331,7 @@ config DRM_TTM_HELPER > tristate > depends on DRM > select DRM_TTM > + select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help > Helpers for ttm-based gem objects > > @@ -345,6 +345,7 @@ config DRM_GEM_DMA_HELPER > config DRM_GEM_SHMEM_HELPER > tristate > depends on DRM && MMU > + select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help > Choose this if you need the GEM shmem helper functions > > -- > 2.46.0 > >
