-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Thomas Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: simona@xxxxxxxx; airlied@xxxxxxxxx; javierm@xxxxxxxxxx; jfalempe@xxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx; Thomas Zimmermann <tzimmermann@xxxxxxx>; lkp <lkp@xxxxxxxxx>; Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
Subject: [PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO
>
> Commit 808a40b69468 ("drm/fbdev-dma: Implement damage handling and
> deferred I/O") added deferred I/O for fbdev-dma. Also select the
> Kconfig symbol FB_DEFERRED_IO (via FB_DMAMEM_HELPERS_DEFERRED). Fixes
> build errors about missing fbdefio, such as
>
> drivers/gpu/drm/drm_fbdev_dma.c:218:26: error: 'struct drm_fb_helper' has no member named 'fbdefio'
> 218 | fb_helper->fbdefio.delay = HZ / 20;
> | ^~
> drivers/gpu/drm/drm_fbdev_dma.c:219:26: error: 'struct drm_fb_helper' has no member named 'fbdefio'
> 219 | fb_helper->fbdefio.deferred_io = drm_fb_helper_deferred_io;
> | ^~
> drivers/gpu/drm/drm_fbdev_dma.c:221:21: error: 'struct fb_info' has no member named 'fbdefio'
> 221 | info->fbdefio = &fb_helper->fbdefio;
> | ^~
> drivers/gpu/drm/drm_fbdev_dma.c:221:43: error: 'struct drm_fb_helper' has no member named 'fbdefio'
> 221 | info->fbdefio = &fb_helper->fbdefio;
> | ^~
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410050241.Mox9QRjP-lkp@xxxxxxxxx/
> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O")
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.11+
LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
-Jonathan Cavitt
> ---
> drivers/gpu/drm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1df4e627e3d3..db2e206a117c 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -338,7 +338,7 @@ config DRM_TTM_HELPER
> config DRM_GEM_DMA_HELPER
> tristate
> depends on DRM
> - select FB_DMAMEM_HELPERS if DRM_FBDEV_EMULATION
> + select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
> help
> Choose this if you need the GEM DMA helper functions
>
> --
> 2.46.0
>
>
