Re: [PATCH V3 07/11] accel/amdxdna: Add command execution

[Lizhi Hou <lizhi.hou@xxxxxxx>]

On 10/4/24 11:01, Jeffrey Hugo wrote:
> On 9/11/2024 12:06 PM, Lizhi Hou wrote:
> > +enum amdxdna_cmd_type {
> > +    AMDXDNA_CMD_SUBMIT_EXEC_BUF = 0,
> > +    AMDXDNA_CMD_SUBMIT_DEPENDENCY,
> > +    AMDXDNA_CMD_SUBMIT_SIGNAL,
> > +};
> > +
> > +/**
> > + * struct amdxdna_drm_exec_cmd - Execute command.
> > + * @ext: MBZ.
> > + * @ext_flags: MBZ.
>
> I see a check for ext_flags, but not ext

I will add the check.


Thanks,

Lizhi

> > + * @hwctx: Hardware context handle.
> > + * @type: One of command type in enum amdxdna_cmd_type.
> > + * @cmd_handles: Array of command handles or the command handle itself
> > + *               in case of just one.
> > + * @args: Array of arguments for all command handles.
> > + * @cmd_count: Number of command handles in the cmd_handles array.
> > + * @arg_count: Number of arguments in the args array.
> > + * @seq: Returned sequence number for this command.
> > + */
> > +struct amdxdna_drm_exec_cmd {
> > +    __u64 ext;
> > +    __u64 ext_flags;
> > +    __u32 hwctx;
> > +    __u32 type;
> > +    __u64 cmd_handles;
> > +    __u64 args;
> > +    __u32 cmd_count;
> > +    __u32 arg_count;
> > +    __u64 seq;
> > +};