Re: [PATCH V3 06/11] accel/amdxdna: Add GEM buffer object management

[Lizhi Hou <lizhi.hou@xxxxxxx>]

On 10/4/24 10:56, Jeffrey Hugo wrote:
> On 9/11/2024 12:05 PM, Lizhi Hou wrote:
> > +/**
> > + * struct amdxdna_drm_create_bo - Create a buffer object.
> > + * @flags: Buffer flags. MBZ.
> > + * @type: Buffer type.
> > + * @pad1: MBZ.
> > + * @vaddr: User VA of buffer if applied. MBZ.
> > + * @size: Size in bytes.
> > + * @handle: Returned DRM buffer object handle.
> > + * @pad2: MBZ.
> > + */
> > +struct amdxdna_drm_create_bo {
> > +    __u64    flags;
> > +    __u32    type;
> > +    __u32    pad1;
> > +    __u64    vaddr;
> > +    __u64    size;
> > +    __u32    handle;
> > +    __u32    pad2;
> > +};
>
> Why not eliminate both padding fields by either moving "handle" up, or 
> "type" down?

Ok. I will change this.


Thanks,

Lizhi