Hello, On Tue, Oct 01, 2024 at 11:37:35PM -0400, Alex Lanzano wrote: > This patch series add support for the monochrome Sharp Memory LCD > panels. This series is based off of the work done by Mehdi Djait. > > References: > https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.djait@xxxxxxxxxxx/ > https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf > > Co-developed-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxx> > Signed-off-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxx> > Signed-off-by: Alex Lanzano <lanzano.alex@xxxxxxxxx> > --- > Changes in v8: > - Addressed review comments from Uwe > - Replace pwm_get_state with pwm_init_state > - Use pwm_set_relative_duty_cycle instead of manually setting period and duty cycle You didn't explicitly mention that it's fine if the PWM doesn't emit the inactive state when you call pwm_disable(). You're code should continue to work if you drop all calls to pwm_disable(). Ideally you mention that in a code comment to make others reading your code understand that. Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
