On Thu, Sep 19, 2024 at 10:01:06AM +0000, Winkler, Tomas wrote:
> > On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote:
> > > +static int intel_dg_spi_write(struct mtd_info *mtd, loff_t to, size_t len,
> > > + size_t *retlen, const u_char *buf) {
> > > + return 0;
> > > +}
> > If these functions can legitimately be empty they should be removed.
> Those are place holder so the code will compile and implemented in following patches, this is compromise on not making too big changes.
> It use dot be acceptable compromise in past.
If you omit the functions you should obviously entirely omit them
entirely, including putting them in relevant ops struct. As things
stand this just makes the code look buggy which doesn't help review,
you're adding functions which obviously don't work properly and not even
noting that in the changelog or code. Just add the assignment of the
ops when you add the implementation of the ops, that way there's no
partially implemented step.
Attachment:
signature.asc
Description: PGP signature
