>
> On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote:
>
> > From: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> >
> > Register the on-die spi device with the mtd subsystem.
> > Refcount spi object on _get and _put mtd callbacks.
>
> This is a MTD driver, it should be in drivers/mtd.
Okay.
>
> > +static int intel_dg_spi_erase(struct mtd_info *mtd, struct erase_info
> > +*info) {
> > + return 0;
> > +}
> > +
> > +static int intel_dg_spi_read(struct mtd_info *mtd, loff_t from, size_t len,
> > + size_t *retlen, u_char *buf)
> > +{
> > + return 0;
> > +}
> > +
> > +static int intel_dg_spi_write(struct mtd_info *mtd, loff_t to, size_t len,
> > + size_t *retlen, const u_char *buf) {
> > + return 0;
> > +}
>
> If these functions can legitimately be empty they should be removed.
Those are place holder so the code will compile and implemented in following patches, this is compromise on not making too big changes.
It use dot be acceptable compromise in past.
