On Thu, Sep 19, 2024 at 09:55:54AM +0000, Winkler, Tomas wrote:
> > On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote:
> > > In intel-dg spi, there is no access to the spi controller, the
> > > information is extracted from the descriptor region.
> > Which information? I can't tell what this patch is supposed to do; as with the
> > first patch this shouldn't be standalone.
> The patch series was built for review, it adds functionality on top of each other.
That's not worked out well here - like I say I can't tell what the patch
is supposed to be doing. What information is supposed to be read here,
why?
> > > +static inline u32 spi_error(struct intel_dg_spi *spi) {
> > > +static inline u32 spi_read32(struct intel_dg_spi *spi, u32 address) {
> > At least these names are too generic, please use driver specific prefixes.
> Can be done but those functions are local to the driver not part of the API.
Sure, the issue is that a core API with the same name could reasonably
be added at which point it'll collide with the driver internals.
Attachment:
signature.asc
Description: PGP signature
