Hi Zhang,
On Fri, Sep 13, 2024 at 10:07:21PM GMT, Zhang He wrote:
> column header should be GPU, not CPU
>
> Signed-off-by: Zhang He <zhanghe9702@xxxxxxx>
Thanks for having fixed the issues I pointed out. Said that, for
the next patches:
1. Add a versioning. This is version number 2, so that yo uneed
to do "git format patch -v 2...."
2. Add the changelog: you need to list the differences between
the two versions, so that people are aware of what changes to
look for. You can do it after the "---' section in this patch.
For this patch the difference would be the use of your correct
name as Author and as Signer.
3. Add the tags that you collected in the previous version of the
patch. I did review your change, so that you should have added
my:
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
For now it's OK, your patch is accepted, I will merge it and then
I will notify you.
Thanks for having sent your change and for following up on the
review,
Andi
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 8d08b38874ef..b635aa2820d9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -431,7 +431,7 @@ static int llc_show(struct seq_file *m, void *data)
> max_gpu_freq /= GEN9_FREQ_SCALER;
> }
>
> - seq_puts(m, "GPU freq (MHz)\tEffective CPU freq (MHz)\tEffective Ring freq (MHz)\n");
> + seq_puts(m, "GPU freq (MHz)\tEffective GPU freq (MHz)\tEffective Ring freq (MHz)\n");
>
> wakeref = intel_runtime_pm_get(gt->uncore->rpm);
> for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {
> --
> 2.34.1
>
