Hi, On Tue, Sep 10, 2024 at 10:10:04PM GMT, 张河 wrote: > :), i think you mean should use CPU column head? because the reg value just > reflect CPU related information before getting into it, please, keep in mind: 1. do not top post. 2. do not send html e-mails. 3. read carefully the reviews from reviewers. Said that, I asked you: 1. include the proper mailing lists when you send patches (use get_maintainers.pl) 2. Do you really want to use "zhanghe9702" as a name rather than your real "Name Surname" as everyone does? Andi > At 2024-09-10 17:24:32, "Andi Shyti" <andi.shyti@xxxxxxxxxxxxxxx> wrote: > >Hi Zhanghe, > > > >Thanks for your patch. Please next time check from > >get_maintainers.pl the mailing lists that need to be included in > >your patches. > > > >In this case you should have included at least the > >intel-gfx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx> and the > >dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx> mailing lists. > > > >On Sat, Sep 07, 2024 at 05:24:43PM +0800, zhanghe9702 wrote: > >> column header should be GPU, not CPU > >> > >> Signed-off-by: zhanghe9702 <zhanghe9702@xxxxxxx> > > > >Do you really want your name to appear as zhanghe9702? If you git > >log the linux directory you will se that people normally use > >the "Name Surname <email>" style. As you wish. > > > >> --- > >> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > >> index 8d08b38874ef..b635aa2820d9 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > >> @@ -431,7 +431,7 @@ static int llc_show(struct seq_file *m, void *data) > >> max_gpu_freq /= GEN9_FREQ_SCALER; > >> } > >> > >> - seq_puts(m, "GPU freq (MHz)\tEffective CPU freq (MHz)\tEffective Ring freq (MHz)\n"); > >> + seq_puts(m, "GPU freq (MHz)\tEffective GPU freq (MHz)\tEffective Ring freq (MHz)\n"); > > > >This is correct: > > > >Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > > > >Thanks, > >Andi >
