On 8/30/2024 9:38 AM, Dmitry Baryshkov wrote:
On Thu, Aug 29, 2024 at 01:48:23PM GMT, Jessica Zhang wrote:
Add clone mode status to the DRM atomic print state
Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>
---
drivers/gpu/drm/drm_atomic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 07b4b394e3bf..145d6a758d4d 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -455,6 +455,7 @@ static void drm_atomic_crtc_print_state(struct drm_printer *p,
drm_printf(p, "\tconnector_mask=%x\n", state->connector_mask);
drm_printf(p, "\tencoder_mask=%x\n", state->encoder_mask);
drm_printf(p, "\tmode: " DRM_MODE_FMT "\n", DRM_MODE_ARG(&state->mode));
+ drm_printf(p, "\tin_clone_mode=%d\n", drm_crtc_in_clone_mode(crtc->state));
We have encoder_mask two lines above. What is the benefit of having the
separate in_clone_mode?
Hi Dmitry,
I was thinking that this would be an easy way to note if a CRTC was in
clone mode, but I can see why this is redundant.
Will drop this patch.
Thanks,
Jessica Zhang
if (crtc->funcs->atomic_print_state)
crtc->funcs->atomic_print_state(p, state);
--
2.34.1
--
With best wishes
Dmitry
