...so, unless I'm mistaken, the other users of this panel driver still need the drm_connector_set_panel_orientation() call here and you shouldn't remove it. Perhaps Alexander Warnecke could comment about whether this is still needed. ...or perhaps someone who maintains Rockchip DRM can say whether they have any plans around this area? If, for some reason, you do remove it then it should at least be called out in the description since this is a functionality change. -Doug