Hi,
On Tue, Jul 16, 2024 at 5:11 AM Zhaoxiong Lv
<lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Use public functions(drm_connector_helper_get_modes_fixed()) to
> get porch parameters.
>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> .../drm/panel/panel-boe-th101mb31ig002-28a.c | 26 ++-----------------
> 1 file changed, 2 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> index d4e4abd103bb..4a61a11099b6 100644
> --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
> @@ -16,6 +16,7 @@
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_modes.h>
> #include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
>
> struct boe_th101mb31ig002;
>
> @@ -313,31 +314,8 @@ static int boe_th101mb31ig002_get_modes(struct drm_panel *panel,
> struct boe_th101mb31ig002,
> panel);
> const struct drm_display_mode *desc_mode = ctx->desc->modes;
> - struct drm_display_mode *mode;
>
> - mode = drm_mode_duplicate(connector->dev, desc_mode);
> - if (!mode) {
> - dev_err(panel->dev, "Failed to add mode %ux%u@%u\n",
> - desc_mode->hdisplay, desc_mode->vdisplay,
> - drm_mode_vrefresh(desc_mode));
> - return -ENOMEM;
> - }
> -
> - drm_mode_set_name(mode);
> -
> - connector->display_info.bpc = 8;
I notice that drm_connector_helper_get_modes_fixed() doesn't seem to
set bpc. Unless I'm mistaken and that gets set automatically somewhere
else then you should keep that, right?
> - connector->display_info.width_mm = mode->width_mm;
> - connector->display_info.height_mm = mode->height_mm;
> -
> - /*
> - * TODO: Remove once all drm drivers call
> - * drm_connector_set_orientation_from_panel()
> - */
> - drm_connector_set_panel_orientation(connector, ctx->orientation);
Are we confident that all the other users of this panel are properly
getting the orientation and we can remove the above bit of code? It
looks like one other user is 'rk3566-pinetab2'.
