Hi, On Mon, Jul 15, 2024 at 7:22 AM Doug Anderson <dianders@xxxxxxxxxx> wrote: > > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms. > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > FWIW things have changed enough between V1 and V2 that you probably > should have removed Conor's "Acked-by" tag here and waited for him to > re-add it. > > I'd also note that when posting a patch your Signed-off-by should > always be at the bottom of any collected tags. For reference [1]. > > [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/ > > That being said, the new binding seems OK to me. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> ...also, all of your patches seem to have the wrong address for Benjamin Tissoires. Can you fix that? I keep getting: Message not delivered Your message couldn't be delivered to benjamin.tissoires@xxxxxxxxx because the remote server is misconfigured. See technical details below for more information. ...because you have ".co" instead of ".com". Having the wrong email address for the maintainer is a good way for your patch not to get picked up. :-P I would further note that Benjamin seems to have moved from using his "redhat.com" address to his "kernel.org" address. See commit 139b4c37e9cb ("MAINTAINERS: update Benjamin's email address"). One last note is that get_maintainers should have suggested you email my @chromium.org address rather than my @google.com address. It's not a huge deal since they both come to the same place, but some maintainer tools will refuse to accept the "Reviewed-by" that I post with my @chromium.org address because my mail program will notice you sent to my @google.com address and send my reply from there. Probably you should be using a tool like "b4" or "patman" to help you send your patches out [1]. [1] https://youtu.be/7B3nKmBoFoQ -Doug
