On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms. > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > FWIW things have changed enough between V1 and V2 that you probably > should have removed Conor's "Acked-by" tag here and waited for him to > re-add it. Yeah, good spot. I wouldn't have acked this version would asking questions - in v1 it made sense not to have a fallback when "they have a different post power delay ms", but now there is a fallback. Is the fallback actually suitable here, or might it be a naive rebase? Does the ekth6a12nay work with the ekth6915's reset timing? Thanks, Conor. > > I'd also note that when posting a patch your Signed-off-by should > always be at the bottom of any collected tags. For reference [1]. > > [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/ > > That being said, the new binding seems OK to me. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
