Re: [PATCH v2 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 03, 2024 at 10:31:46PM +1200, Ryan Walklin wrote:
> make dt_bindings_check reports that sck-gpios and num-chipselects are
> required for spi nodes, therefore add these to the example.
> 
> Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx>

I forgot to reply to, or somehow didn't notice your reply to my comments
on this patch. I would just drop this change as I think it's a tooling
issue. I checked the version of dt-schema etc that I have here locally
and there were no complaints with the binding prior to your patches.

Sorry for missing your reply,
Conor.

> ---
>  .../bindings/display/panel/anbernic,wl-355608-a8.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> index dde3600f0189c..bbe016453c9b2 100644
> --- a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> @@ -40,6 +40,9 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> +        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
> +        num-chipselects = <1>;
> +
>          panel@0 {
>              compatible = "anbernic,wl-355608-a8";
>              reg = <0>;
> -- 
> 2.45.2
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux