On 19/06/2024 14:00, Jacopo Mondi wrote: > Hi Krzysztof > > On Wed, Jun 19, 2024 at 01:07:24PM GMT, Krzysztof Kozlowski wrote: >> On 19/06/2024 12:22, Jacopo Mondi wrote: >>> Add support for R-Car R8A779H0 V4M which has the same characteristics >>> of the already supported R-Car V4H R8A779G0. >>> >>> Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> >>> >> >> Please run scripts/checkpatch.pl and fix reported warnings. Then please >> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. >> Some warnings can be ignored, especially from --strict run, but the code >> here looks like it needs a fix. Feel free to get in touch if the warning >> is not clear. >> > > The only report I got was > > WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > > which for such trivial addition seems overkill, and I presume the > patch will go through geert or drm anyway That's still the preference. Having patches, even when trivial, tested via automation as well. Best regards, Krzysztof