Hi Krzysztof On Wed, Jun 19, 2024 at 01:07:24PM GMT, Krzysztof Kozlowski wrote: > On 19/06/2024 12:22, Jacopo Mondi wrote: > > Add support for R-Car R8A779H0 V4M which has the same characteristics > > of the already supported R-Car V4H R8A779G0. > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > > > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. > The only report I got was WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst which for such trivial addition seems overkill, and I presume the patch will go through geert or drm anyway The other thing I got CHECK: Prefer using the BIT macro #30: FILE: drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h:144: makes sense, but the rest of the file already uses (1 << x) so I kept it that way for consistency (honestly I would have changed all defines to use BIT() but that would make upporting from BSP quite more tedious). Is there any other warning I have missed ? > Bindings are separate patches. > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> > > Best regards, > Krzysztof >
