On 6/17/24 17:17, Jason Gunthorpe wrote: > [You don't often get email from jgg@xxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote: >> Add an RDMA driver of Gaudi ASICs family for AI scaling. >> The driver itself is agnostic to the ASIC in action, it operates according >> to the capabilities that were passed on device initialization. >> The device is initialized by the hbl_cn driver via auxiliary bus. >> The driver also supports QP resource tracking and port/device HW counters. > > I'm glad to finally see this, I've been talking to habana folks a long > time now to get this worked out! > > This will need to be split up more, like others have said. I'd post > the RDMA series assuming that the basic ethernet driver is merged. You > don't need to combine basic ethernet with rdma in the same series. > > Jason Yeah, I'll push one driver at a time in multiple patch sets with smaller patches. It's just that all the 4 drivers are operating together, they are not operational separately. That's why I thought it will give more context to see the entire picture when reviewing.