On 6/18/24 19:01, Przemek Kitszel wrote: > On 6/18/24 13:08, Omer Shpigelman wrote: >> On 6/17/24 22:04, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from leon@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>> >>> On Mon, Jun 17, 2024 at 05:43:49PM +0000, Omer Shpigelman wrote: >>>> On 6/13/24 22:18, Leon Romanovsky wrote: >>>>> [Some people who received this message don't often get email from leon@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>>>> >>>>> On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote: >>>>>> Add an RDMA driver of Gaudi ASICs family for AI scaling. >>>>>> The driver itself is agnostic to the ASIC in action, it operates according >>>>>> to the capabilities that were passed on device initialization. >>>>>> The device is initialized by the hbl_cn driver via auxiliary bus. >>>>>> The driver also supports QP resource tracking and port/device HW counters. >>>>>> >>>>>> Signed-off-by: Omer Shpigelman <oshpigelman@xxxxxxxxx> >>>>>> Co-developed-by: Abhilash K V <kvabhilash@xxxxxxxxx> >>>>>> Signed-off-by: Abhilash K V <kvabhilash@xxxxxxxxx> >>>>>> Co-developed-by: Andrey Agranovich <aagranovich@xxxxxxxxx> >>>>>> Signed-off-by: Andrey Agranovich <aagranovich@xxxxxxxxx> >>>>>> Co-developed-by: Bharat Jauhari <bjauhari@xxxxxxxxx> >>>>>> Signed-off-by: Bharat Jauhari <bjauhari@xxxxxxxxx> >>>>>> Co-developed-by: David Meriin <dmeriin@xxxxxxxxx> >>>>>> Signed-off-by: David Meriin <dmeriin@xxxxxxxxx> >>>>>> Co-developed-by: Sagiv Ozeri <sozeri@xxxxxxxxx> >>>>>> Signed-off-by: Sagiv Ozeri <sozeri@xxxxxxxxx> >>>>>> Co-developed-by: Zvika Yehudai <zyehudai@xxxxxxxxx> >>>>>> Signed-off-by: Zvika Yehudai <zyehudai@xxxxxxxxx> >>>>> >>>>> I afraid that you misinterpreted the "Co-developed-by" tag. All these >>>>> people are probably touch the code and not actually sit together at >>>>> the same room and write the code together. So, please remove the >>>>> extensive "Co-developed-by" tags. >>>>> >>>>> It is not full review yet, but simple pass-by-comments. >>>>> >>>> >>>> Actually except of two, all of the mentioned persons sat in the same room >>>> and developed the code together. >>>> The remaining two are located on a different site (but also together). >>>> Isn't that what "Co-developed-by" tag for? >>>> I wanted to give them credit for writing the code but I can remove if it's >>>> not common. >>> >>> Signed-off-by will be enough to give them credit. >>> >> >> Ok, good enough. >> > > I would say that a lone sign-off give a little of credit compared to the > co-developed-by tag. OTOH the list here is unusually long. What makes it > even more tricky to evaluate is the fact that there is a lot of code ;) > > So, I would suggest to re-evaluate this on your next (trimmed down) > revisions. You are right about the smaller credit Signed-off-by gives compared to Co-developed-by, but yeah, the list is unusually long. I'll try to split it to smaller patches and give credit only to the specific persons involved.
