On 23.05.24 20:58, Måns Rullgård wrote: > Måns Rullgård <mans@xxxxxxxxx> writes: >> Frank Oltmanns <frank@xxxxxxxxxxxx> writes: >>> 21.05.2024 15:43:10 Måns Rullgård <mans@xxxxxxxxx>: >>>> Frank Oltmanns <frank@xxxxxxxxxxxx> writes: >>>> >>>>> The Allwinner SoC's typically have an upper and lower limit for their >>>>> clocks' rates. Up until now, support for that has been implemented >>>>> separately for each clock type. >>>>> >>>>> Implement that functionality in the sunxi-ng's common part making use of >>>>> the CCF rate liming capabilities, so that it is available for all clock >>>>> types. >>>>> >>>>> Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx> >>>>> Signed-off-by: Frank Oltmanns <frank@xxxxxxxxxxxx> >>>>> Cc: stable@xxxxxxxxxxxxxxx >>>>> --- >>>>> drivers/clk/sunxi-ng/ccu_common.c | 19 +++++++++++++++++++ >>>>> drivers/clk/sunxi-ng/ccu_common.h | 3 +++ >>>>> 2 files changed, 22 insertions(+) >>>> >>>> This just landed in 6.6 stable, and it broke HDMI output on an A20 based >>>> device, the clocks ending up all wrong as seen in this diff of >>>> /sys/kernel/debug/clk/clk_summary: > [...] > >>>> Reverting this commit makes it work again. >>> Thank you for your detailed report! > [...] > It turns out HDMI output is broken in v6.9 for a different reason. > However, this commit (b914ec33b391 clk: sunxi-ng: common: Support > minimum and maximum rate) requires two others as well in order not > to break things on the A20: > > cedb7dd193f6 drm/sun4i: hdmi: Convert encoder to atomic > 9ca6bc246035 drm/sun4i: hdmi: Move mode_set into enable > > With those two (the second depends on the first) cherry-picked on top of > v6.6.31, the HDMI output is working again. Likewise on v6.8.10. They from what I can see are not yet in 6.6.y or on their way there (6.8 is EOL now). Did anyone ask Greg to pick this up? If not: Månsm could you maybe do that? CCing him on a reply and asking is likely enough if both changes apply cleanly. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot introduced: 547263745e15a0 #regzbot fix: drm/sun4i: hdmi: Move mode_set into enable #regzbot poke
