On Sat, 8 Jun 2024, at 2:23 AM, Conor Dooley wrote: Thanks for the review! >> --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml >> +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml >> @@ -25,6 +25,7 @@ properties: >> - const: allwinner,sun50i-a64-de2 >> - items: >> - const: allwinner,sun50i-h6-de3 >> + - const: allwinner,sun50i-h616-de33 >> - const: allwinner,sun50i-a64-de2 > > This does not do what you think it does! > It needs to be > items: > - enum: > - h6 > - h616 > - const: a64 > Thanks, will correct in v2. >> + - const: allwinner,sun50i-h616-de33-clk > > I think this is not right, as a corresponding driver change is missing. > Either you're missing a clock driver patch or you didn't test your dts. The clock driver patch with this compatible string is in patch 8/8. >> - allwinner,sun50i-h6-de3-mixer-0 >> + - allwinner,sun50i-h616-de33-mixer-0 > > Your commit message should mention why a fallback is not suitable here. Will do, thanks. > > Thanks, > Conor. > Regards, Ryan
