On Wed, 15 May 2024, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 15 May 2024 at 16:17, Dave Airlie <airlied@xxxxxxxxx> wrote: >> AMDGPU, I915 and XE all have !COMPILE_TEST on their variants > > Hmm. It turns out that I didn't notice the AMDGPU one because my > Threadripper - that has AMDGPU enabled - I have actually turned off > EXPERT on, so it's hidden by that for me. > > But yes, both of those should be "depends on !WERROR" too. Fair enough. Honestly it just didn't occur to me. The main goal here was to ensure the drm subsystem does not have any build warnings, but without halting CI on any non-drm warnings that might occasionally creep in and that we can't fix as quickly. If there was a way to somehow limit WERROR by subdirectories, without config options, I'd love to ditch the config. > Or maybe they should just go away entirely, and be subsumed by the > DRM_WERROR thing. For i915, this was the idea anyway, we just haven't gotten around to it yet. BR, Jani. -- Jani Nikula, Intel
