On Wed, 15 May 2024 at 16:17, Dave Airlie <airlied@xxxxxxxxx> wrote: > > It's also possible it's just that hey there's a few others in the tree > > KVM_WERROR not tied to it > PPC_WERROR (why does CXL uses this?) Yeah, that should be fixed too, but at least KVM_WERROR predates the whole-kernel WERROR. And PPC_WERROR predates it by over a decade. But yes, good catch - both of those should be silenced if we already have the global WERROR enabled. I mainly notice new questions (because I use "make oldconfig"), so old pre-existing illogical ones don't trigger my "why are they asking?" reaction. > AMDGPU, I915 and XE all have !COMPILE_TEST on their variants Hmm. It turns out that I didn't notice the AMDGPU one because my Threadripper - that has AMDGPU enabled - I have actually turned off EXPERT on, so it's hidden by that for me. But yes, both of those should be "depends on !WERROR" too. Or maybe they should just go away entirely, and be subsumed by the DRM_WERROR thing. Linus