Re: [PATCH 06/12] accel/ivpu: Implement support for hardware scheduler

[Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx>]

Hi,

On 10.05.2024 18:41, Jeffrey Hugo wrote:
> On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote:
>> +#define IVPU_FOCUS_PRESENT_TIMER_MS 1000
>> +
>>   static char *ivpu_firmware;
>>   module_param_named_unsafe(firmware, ivpu_firmware, charp, 0644);
>>   MODULE_PARM_DESC(firmware, "NPU firmware binary in /lib/firmware/..");
>> @@ -467,6 +469,10 @@ static void ivpu_fw_boot_params_print(struct ivpu_device *vdev, struct vpu_boot_
>>            boot_params->punit_telemetry_sram_size);
>>       ivpu_dbg(vdev, FW_BOOT, "boot_params.vpu_telemetry_enable = 0x%x\n",
>>            boot_params->vpu_telemetry_enable);
>> +    ivpu_dbg(vdev, FW_BOOT, "boot_params.vpu_scheduling_mode = 0x%x\n",
>> +         boot_params->vpu_scheduling_mode);
>> +    ivpu_dbg(vdev, FW_BOOT, "boot_params.vpu_focus_present_timer_ms = %u\n",
>> +         boot_params->vpu_focus_present_timer_ms);
> 
> The timer value is hard coded.  Does that not make this log message redundant?

Yes, I will remove it.