Hi, On 10.05.2024 18:30, Jeffrey Hugo wrote: > On 5/8/2024 7:20 AM, Jacek Lawrynowicz wrote: >> From: "Wachowski, Karol" <karol.wachowski@xxxxxxxxx> >> >> This param will be used to enable/disable HWS (hardware scheduler). >> The HWS is a FW side feature and may not be available on all >> HW generations and FW versions. >> >> Signed-off-by: Wachowski, Karol <karol.wachowski@xxxxxxxxx> >> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx> >> --- >> drivers/accel/ivpu/ivpu_drv.c | 4 ++++ >> drivers/accel/ivpu/ivpu_drv.h | 1 + >> drivers/accel/ivpu/ivpu_hw.h | 3 ++- >> drivers/accel/ivpu/ivpu_hw_37xx.c | 1 + >> drivers/accel/ivpu/ivpu_hw_40xx.c | 3 ++- >> 5 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c >> index 51d3f1a55d02..db47e7ef6322 100644 >> --- a/drivers/accel/ivpu/ivpu_drv.c >> +++ b/drivers/accel/ivpu/ivpu_drv.c >> @@ -51,6 +51,10 @@ u8 ivpu_pll_max_ratio = U8_MAX; >> module_param_named(pll_max_ratio, ivpu_pll_max_ratio, byte, 0644); >> MODULE_PARM_DESC(pll_max_ratio, "Maximum PLL ratio used to set NPU frequency"); >> +bool ivpu_sched_mode; >> +module_param_named(sched_mode, ivpu_sched_mode, bool, 0644); >> +MODULE_PARM_DESC(sched_mode, "Scheduler mode: 0 - OS scheduler, 1 - HW scheduler"); > > "OS scheduler" > Host OS (aka Linux) or device side OS? Seems a bit ambiguous. Yeah, it should be "No scheduler". We actually don't have any OS scheduling for workloads. > Also looks like this must be set before the device is initialized, yet it does not look like that is communicated. I'm usually try to keep param descriptions short. I will change the mode to 0444, so it won't be possible to change the param after driver is loaded.
