On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote: > So you are now hard-coding the size? Yes, the change just helps developers who want to adapt to different screen sizes. > Is this always going to be 0, if so, why need it at all? Not sure. For example, when HEIGHT and WIDTH are 240 and 280, LEFT_OFFSET is 20 and TOP_OFFSET is 0. Different screens may have different offsets. In addition, do I need to resend the patch to modify the Signed-off-by? thanks, purofle