On Sat, Apr 06, 2024 at 12:57:47AM +0800, purofle wrote: > Some screen sizes using st7789v chips are different from 240x320, > and offsets need to be set to display all images properly. > > Signed-off-by: purofle <purofle@xxxxxxxxx> We need a semi-real name here please. > --- > drivers/staging/fbtft/fb_st7789v.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c > index 861a15414..d47ab4262 100644 > --- a/drivers/staging/fbtft/fb_st7789v.c > +++ b/drivers/staging/fbtft/fb_st7789v.c > @@ -30,6 +30,12 @@ > > #define HSD20_IPS 1 > > +#define WIDTH 240 > +#define HEIGHT 320 So you are now hard-coding the size? > + > +#define LEFT_OFFSET 0 > +#define TOP_OFFSET 0 Is this always going to be 0, if so, why need it at all? thanks, greg k-h
