On Tue, 05 Mar 2024, Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> Hmm. As Hsin-Yi pointed out to me offline. Somehow we'll need to get >> the actual panel ID out. Right now in panel-edp.c we have: >> >> dev_warn(dev, >> "Unknown panel %s %#06x, using conservative timings\n", >> vend, product_id); >> >> Where "vend" and "product_id" come from the panel ID of a panel that >> we didn't recognize. For instance: >> >> Unknown panel BOE 0x0731, using conservative timings >> >> We need to still be able to print this message for unrecognized >> panels. Then when we see field reports including this message we know >> that somehow we ended up shipping an unrecognized panel. >> >> Any suggestions on what abstraction you'd like to see to enable us to >> print that message if everything is opaque? > > Sent v4 here: https://lore.kernel.org/lkml/20240306004347.974304-1-hsinyi@xxxxxxxxxxxx/ > > Besides that it still keeps drm_edid_get_panel_id() to be used on the > kernel warning when no panel is matched, other parts I think are > following the comments. Yeah we can keep that for now. BR, Jani. -- Jani Nikula, Intel
