On Mon, 04 Mar 2024, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > Hi, > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: >> >> > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid >> > > *);? Given that we still need to parse id from >> > > drm_edid_read_base_block(). >> > >> > No, we no longer need to parse the id outside of drm_edid.c. You'll have >> > the id's in panel code in the form of struct drm_edid_ident (or >> > whatever), and use the match function to see if the opaque drm_edid >> > matches. >> > >> drm_panel prints the panel_id info on whether the panel is detected or not. >> https://elixir.bootlin.com/linux/v6.8-rc7/source/drivers/gpu/drm/panel/panel-edp.c#L792 >> >> Is it okay to remove this information? > > Hmmm, I guess it also is exported via debugfs, actually. See > detected_panel_show() in panel-edp.c. We probably don't want to remove > that... You currently print the information via panel->detected_panel, which is a struct edp_panel_entry *. That doesn't change. It'll be slightly restructured to contain a struct drm_edid_ident, which will not be an opaque type. BR, Jani. -- Jani Nikula, Intel
