On Fri, Feb 23, 2024 at 11:32:21PM +0200, Ville Syrjälä wrote: > On Tue, Feb 20, 2024 at 11:18:22PM +0200, Imre Deak wrote: > > +static inline void drm_dp_tunnel_ref_put(struct drm_dp_tunnel_ref *tunnel_ref) > > +{ > > + drm_dp_tunnel_put(tunnel_ref->tunnel, &tunnel_ref->tracker); > > Should we set tunnel_ref->tunnel=NULL here? Yes, thanks for spotting this. It also fixes intel_crtc_prepare_cleared_state()-> intel_dp_tunnel_atomic_clear_stream_bw() if crtc_state::dp_tunnel_ref state doesn't get recomputed, for instance when disabling the crtc. > > -- > Ville Syrjälä > Intel