On Thu, 15 Feb 2024, Thomas Zimmermann wrote: > Hi > > Am 15.02.24 um 13:13 schrieb Daniel Thompson: > > On Mon, Feb 12, 2024 at 05:16:33PM +0100, Thomas Zimmermann wrote: > > > Backlight drivers implement struct backlight_ops.check_fb, which > > > uses struct fb_info in its interface. Replace the callback with one > > > the does not use fb_info. > > > > > > In DRM, we have several drivers that implement backlight support. By > > > including <linux/backlight.h> these drivers depend on <linux/fb.h>. > > > At the same time, fbdev is deprecated for new drivers and likely to > > > be replaced on many systems. > > > > > > This patchset is part of a larger effort to implement the backlight > > > code without depending on fbdev. > > > > > > Patch 1 makes the backlight core match backlight and framebuffer > > > devices via struct fb_info.bl_dev. Patches 2 to 9 then go through > > > drivers and remove unnecessary implementations of check_fb. Finally, > > > patch 10 replaces the check_fb hook with controls_device, which > > > uses the framebuffer's Linux device instead of the framebuffer. > > I won't reply individually but I also took a look at the patches for > > the combo devices and it all looked good to me from a backlight > > point of view. > > > > However I don't want to drop Reviewed-by: on them since it risks those > > bit being mistaken for an ack and merged ahead of the patch 1... > > Thanks for reviewing. Unless someone objects, my intention is to merge > everything via the drm-misc, so all patches should go in at once. I do have > a lot more patches that untangle backlight and fbdev almost completely, but > most of these changes are in the actual graphics drivers rather than the > backlight core code. So hopefully everything can go through the DRM tree; or > maybe the fbdev tree. This is only acceptable if the maintainers of those trees can provide me with a pull-request to a succinct (_only_ these patches) immutable branch. If this is not possible, then I should like to merge the set through the Backlight tree and I can provide everyone else with said PR. -- Lee Jones [李琼斯]
