On Mon, Feb 12, 2024 at 05:16:33PM +0100, Thomas Zimmermann wrote: > Backlight drivers implement struct backlight_ops.check_fb, which > uses struct fb_info in its interface. Replace the callback with one > the does not use fb_info. > > In DRM, we have several drivers that implement backlight support. By > including <linux/backlight.h> these drivers depend on <linux/fb.h>. > At the same time, fbdev is deprecated for new drivers and likely to > be replaced on many systems. > > This patchset is part of a larger effort to implement the backlight > code without depending on fbdev. > > Patch 1 makes the backlight core match backlight and framebuffer > devices via struct fb_info.bl_dev. Patches 2 to 9 then go through > drivers and remove unnecessary implementations of check_fb. Finally, > patch 10 replaces the check_fb hook with controls_device, which > uses the framebuffer's Linux device instead of the framebuffer. I won't reply individually but I also took a look at the patches for the combo devices and it all looked good to me from a backlight point of view. However I don't want to drop Reviewed-by: on them since it risks those bit being mistaken for an ack and merged ahead of the patch 1... Daniel.
