On Mon, Jan 22, 2024 at 07:12:42PM -0800, Lucas De Marchi wrote:
> Since the PCI IDs for PVC were added to the xe driver, the xe_wa tests
This first line doesn't seem to be worded right. I think you meant
either "weren't added" or "were only added to topic/xe-for-CI."
Assuming you can reword that,
Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> should not try to create a fake PVC device since they can't find
> the right PCI ID. Fix bugs when running kunit:
>
> # xe_wa_gt: ASSERTION FAILED at drivers/gpu/drm/xe/tests/xe_wa_test.c:111
> Expected ret == 0, but
> ret == -19 (0xffffffffffffffed)
> [FAILED] PVC (B0)
> # xe_wa_gt: ASSERTION FAILED at drivers/gpu/drm/xe/tests/xe_wa_test.c:111
> Expected ret == 0, but
> ret == -19 (0xffffffffffffffed)
> [FAILED] PVC (B1)
> # xe_wa_gt: ASSERTION FAILED at drivers/gpu/drm/xe/tests/xe_wa_test.c:111
> Expected ret == 0, but
> ret == -19 (0xffffffffffffffed)
> [FAILED] PVC (C0)
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> ---
> drivers/gpu/drm/xe/tests/xe_wa_test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_wa_test.c b/drivers/gpu/drm/xe/tests/xe_wa_test.c
> index 439477593faf..44570d888355 100644
> --- a/drivers/gpu/drm/xe/tests/xe_wa_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_wa_test.c
> @@ -69,9 +69,6 @@ static const struct platform_test_case cases[] = {
> SUBPLATFORM_CASE(DG2, G10, C0),
> SUBPLATFORM_CASE(DG2, G11, B1),
> SUBPLATFORM_CASE(DG2, G12, A1),
> - PLATFORM_CASE(PVC, B0),
> - PLATFORM_CASE(PVC, B1),
> - PLATFORM_CASE(PVC, C0),
> GMDID_CASE(METEORLAKE, 1270, A0, 1300, A0),
> GMDID_CASE(METEORLAKE, 1271, A0, 1300, A0),
> GMDID_CASE(LUNARLAKE, 2004, A0, 2000, A0),
> --
> 2.43.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
