Am Freitag, 22. Dezember 2023, 12:05:45 CET schrieb Manuel Traut: > devicetree checks show some warnings: > > video-codec@fdea0400: 'interrupt-names' is a required property > from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml# > > hdmi@fe0a0000: Unevaluated properties are not allowed ('power-domains' were unexpected) > from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml# > > i2s@fe420000: reset-names:0: 'm' is not one of ['tx-m', 'rx-m'] > from schema $id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml# > > phy@fe870000: 'power-domains' is a required property > from schema $id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml# > > Fix them by > - setting a interrupt-name for the video-codec > - remove the unevaluated power-domain property from hdmi > - set reset-names according to the spec for i2s > - add a power-domain property for the CSI phy > > Signed-off-by: Manuel Traut <manut@xxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index c19c0f1b3778..651156759582 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -597,6 +597,7 @@ vpu: video-codec@fdea0400 { > compatible = "rockchip,rk3568-vpu"; > reg = <0x0 0xfdea0000 0x0 0x800>; > interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "vdpu"; > clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>; > clock-names = "aclk", "hclk"; > iommus = <&vdpu_mmu>; > @@ -819,7 +820,6 @@ hdmi: hdmi@fe0a0000 { > clock-names = "iahb", "isfr", "cec", "ref"; > pinctrl-names = "default"; > pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>; > - power-domains = <&power RK3568_PD_VO>; are you really sure that the hdmi controller is _not_ part of the VO powerdomain? I.e. Depending on that knowledge it could also simply be necessary to add the property to the binding. Heiko
