On Tue, 28 Nov 2023, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: >> Hi Mani, >> >> On 28/11/23 10:44, Manivannan Sadhasivam wrote: >> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: >> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument >> > > to acquire bus lock") has added an argument to acquire bus lock >> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it >> > > without this argument, resulting in below build error. >> > > >> > >> > Where do you see this error? That patch is not even merged. Looks like you are >> > sending the patch against some downstream tree. >> >> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip >> >> This commit is merged in drm-intel/topic/core-for-CI - >> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI >> > > Okay. Since this patch is just for CI, please do not CC linux-pci as it causes > confusion. Agreed. More on-topic for linux-pci is what happened with [1]. We've been running CI with that for months now to avoid lockdep splats, and it's obviously in everyone's best interest to get a fix upstream. David, Bjorn? BR, Jani. [1] https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@xxxxxxxxxxxxxxx/ > > - Mani > >> Regards, >> Vignesh -- Jani Nikula, Intel