Re: [PATCH 06/11] accel/ivpu: Change test_mode module param to bitmask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/28/2023 2:18 AM, Stanislaw Gruszka wrote:
On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote:
On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
From: Karol Wachowski <karol.wachowski@xxxxxxxxxxxxxxx>

Change meaning of test_mode module parameter from integer value
to bitmask allowing setting different test features with corresponding
bits.

Signed-off-by: Karol Wachowski <karol.wachowski@xxxxxxxxxxxxxxx>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>

Seems like this changes the uAPI.  You still haven't made a release of the
userspace, correct?

Yes the user space is not yet released. However I think module parameter
is not considered part of the linux kernel uAPI and there are no guaranties
regarding not changing or removing or change the semantics.

Patch 3 of [1] seems to suggest otherwise (module parameters are part of the uAPI)

[1]: https://lore.kernel.org/all/20231027193016.27516-1-quic_johmoo@xxxxxxxxxxx/



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux