Hi Chris, Am Freitag, 20. Oktober 2023, 17:03:08 CEST schrieb Chris Morgan: > On Thu, Oct 19, 2023 at 07:45:17PM +0200, Heiko Stübner wrote: > > Hey Chris, > > > > Am Donnerstag, 19. Oktober 2023, 16:43:56 CEST schrieb Chris Morgan: > > > On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > > > > On 18/10/2023 18:18, Chris Morgan wrote: > > > > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > > > > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > > > > powered by the Rockchip RK3566 SoC. > > > > > > > > > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > > --- > > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > index a349bf4da6bc..a6612185a7ff 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > @@ -674,6 +674,11 @@ properties: > > > > > - const: powkiddy,rgb30 > > > > > - const: rockchip,rk3566 > > > > > > > > > > + - description: Powkiddy RK2023 > > > > > + items: > > > > > + - const: powkiddy,rk2023 > > > > > > > > This cuold be just enum in previous entry :/ but I remember we talked > > > > about this once with Heiko. > > > > > > For hardware that requires a different device tree, is that possible? > > > While most of the devices I've worked on for the RK3566 series are very > > > similar for the moment only 1 is identical (the RG353P and the RG353M) > > > and can use the same device tree. > > > > In my reply I pointed to the Rock PI 4A/4A+/B/B+/C family, which also has > > different devicetrees but is part of the same family of device designs. > > > > So similar Powkiddy RK3568 based gaming handhelds also sound like > > a nice family name in the description ;-) . > > Gotcha, I can do that. Would you like for me to go back and do the same > for the Anbernic devices as well? I can do it as part of a seperate > patch series. that doing that for the Anberic devices would be really nice too, so yes please :-) . Thanks Heiko