On Wed, Sep 27, 2023 at 01:33:56PM +0300, Jani Nikula wrote:
> On Tue, 26 Sep 2023, Laurent Pinchart wrote:
> > On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote:
> >> Make drm_bridge_get_edid() the one place to call the hook.
> >>
> >> Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> >> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> >> Cc: Robert Foss <rfoss@xxxxxxxxxx>
> >> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> >> Cc: Jonas Karlman <jonas@xxxxxxxxx>
> >> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> Thanks Laurent, does that cover patch 2/2 as well, or just 1/2?
Just 1/2, I hadn't looked at 2/2. I've now reviewed it too.
> >> ---
> >> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> >> index 1da93d5a1f61..31baf1f5ff81 100644
> >> --- a/drivers/gpu/drm/drm_bridge_connector.c
> >> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> >> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
> >> if (status != connector_status_connected)
> >> goto no_edid;
> >>
> >> - edid = bridge->funcs->get_edid(bridge, connector);
> >> + edid = drm_bridge_get_edid(bridge, connector);
> >> if (!drm_edid_is_valid(edid)) {
> >> kfree(edid);
> >> goto no_edid;
>
> --
> Jani Nikula, Intel
--
Regards,
Laurent Pinchart
