Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Jani,

On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
> 
> Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Cc: Robert Foss <rfoss@xxxxxxxxxx>
> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Jonas Karlman <jonas@xxxxxxxxx>
> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> 
> ---
> 
> UNTESTED

I can't test this either, but it looks fine.

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 22c84d29c2bc..7835738a532e 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
>  	unsigned int count;
>  	struct edid *edid;
>  
> -	edid = lt9611uxc->bridge.funcs->get_edid(&lt9611uxc->bridge, connector);
> +	edid = drm_bridge_get_edid(&lt9611uxc->bridge, connector);
>  	drm_connector_update_edid_property(connector, edid);
>  	count = drm_add_edid_modes(connector, edid);
>  	kfree(edid);

-- 
Regards,

Laurent Pinchart