Re: MAINTAINERS: Update drm-misc entry to match all drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 21, 2023 at 05:09:07PM +0800, Sui Jingfeng wrote:
> On 2023/9/21 16:47, Maxime Ripard wrote:
> > Adding Paul in Cc
> > 
> > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote:
> > > On 2023/9/19 21:12, Maxime Ripard wrote:
> > > > We've had a number of times when a patch slipped through and we couldn't
> > > > pick them up either because our MAINTAINERS entry only covers the
> > > > framework and thus we weren't Cc'd.
> > > > 
> > > > Let's take another approach where we match everything, and remove all
> > > > the drivers that are not maintained through drm-misc.
> > > > 
> > > > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> > > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> > > > ---
> > > >    MAINTAINERS | 23 ++++++++++++++++++++---
> > > >    1 file changed, 20 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 90f13281d297..757d4f33e158 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -6860,12 +6860,29 @@ M:	Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > >    S:	Maintained
> > > >    W:	https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
> > > >    T:	git git://anongit.freedesktop.org/drm/drm-misc
> > > > +F:	Documentation/devicetree/bindings/display/
> > > > +F:	Documentation/devicetree/bindings/gpu/
> > > >    F:	Documentation/gpu/
> > > > -F:	drivers/gpu/drm/*
> > > > +F:	drivers/gpu/drm/
> > > >    F:	drivers/gpu/vga/
> > > > -F:	include/drm/drm*
> > > > +F:	include/drm/drm
> > > >    F:	include/linux/vga*
> > > > -F:	include/uapi/drm/drm*
> > > > +F:	include/uapi/drm/
> > > > +X:	drivers/gpu/drm/amd/
> > > > +X:	drivers/gpu/drm/armada/
> > > > +X:	drivers/gpu/drm/etnaviv/
> > > > +X:	drivers/gpu/drm/exynos/
> > > > +X:	drivers/gpu/drm/gma500/
> > > > +X:	drivers/gpu/drm/i915/
> > > > +X:	drivers/gpu/drm/imx/
> > > > +X:	drivers/gpu/drm/ingenic/
> > > > +X:	drivers/gpu/drm/kmb/
> > > > +X:	drivers/gpu/drm/mediatek/
> > > > +X:	drivers/gpu/drm/msm/
> > > > +X:	drivers/gpu/drm/nouveau/
> > > > +X:	drivers/gpu/drm/radeon/
> > > > +X:	drivers/gpu/drm/renesas/
> > > > +X:	drivers/gpu/drm/tegra/
> > > >    DRM DRIVERS FOR ALLWINNER A10
> > > >    M:	Maxime Ripard <mripard@xxxxxxxxxx>
> > > 
> > > Nice patch!
> > > 
> > > Well, I'm just curious about why the drm/ingenic and drm/gma500 are not maintained through drm-misc?
> > > 
> > > As far as I know:
> > > 1) the drm/ingenic driver don't have a "T" annotation (location of the link).
> > Yeah, I wasn't sure about that one indeed. I remained conservative since it's a
> > sensitive topic for some.
> > 
> > Paul, is drm/ingenic supposed to be maintained through drm-misc? Either way,
> > could you clarify which git tree is supposed to merge those patches in
> > MAINTAINERS?
> > 
> > > 2) the "T" of drm/gma500 is "git git://github.com/patjak/drm-gma500", but the
> >    code for this link is not up to date.
> > 
> > For gma500, I think it's mostly historical since it was there before drm-misc
> > was a thing.
> > 
> > > I think at least the drm/ingenic and drm/gma500 drivers are *actually*
> > > maintained through drm-misc, So perhaps, these two drivers should not be
> > > excluded. Am I correct?
> > It's likely :)
> > 
> > Either way, I think it can be solved/clarified later on
> 
> 
> OK, that's sound fairly enough. I will respect you and Paul's opinion.
> By the way, I also want to say that I think the drm/imb and various drm/imx drivers
> are also belong to the drm-misc. They are also lack the "T" annotation.
> Hopes someone can help to check that. Thanks.
> Thanks for the patch.

As far as I know, imx is kind of in-between at the moment. Some patches
are going through drm-misc, but others are coming through their tree.
For kmb (if that's what you meant), then I would expect intel to do the
maintenance like they do for i915.

But given this discussion it could be a good idea to add all the
maintainers of those excluded drivers in Cc in the next revision.

Maxime

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux