Re: [PATCH 4/6] drm: ci: Enable configs to fix mt8173 boot hang issue

[David Heidelberg <david.heidelberg@xxxxxxxxxxxxx>]

On 08/09/2023 13:23, Vignesh Raman wrote:

> Hi Angelo,
>
> On 07/09/23 16:16, AngeloGioacchino Del Regno wrote:
> > Il 25/08/23 14:24, Vignesh Raman ha scritto:
> > > Enable regulator
> > > Enable MT6397 RTC driver
> > >
> > > Signed-off-by: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>
> > > ---
> > >   drivers/gpu/drm/ci/arm64.config | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/ci/arm64.config 
> > > b/drivers/gpu/drm/ci/arm64.config
> > > index 817e18ddfd4f..ea7a6cceff40 100644
> > > --- a/drivers/gpu/drm/ci/arm64.config
> > > +++ b/drivers/gpu/drm/ci/arm64.config
> > > @@ -184,6 +184,8 @@ CONFIG_HW_RANDOM_MTK=y
> > >   CONFIG_MTK_DEVAPC=y
> > >   CONFIG_PWM_MTK_DISP=y
> > >   CONFIG_MTK_CMDQ=y
> > > +CONFIG_REGULATOR_DA9211=y
> > > +CONFIG_RTC_DRV_MT6397=y
> >
> > I wonder if it'd be a better idea to simply add those to the 
> > defconfig instead as
> >
> > CONFIG_REGULATOR_DA9211=m
> > CONFIG_RTC_DRV_MT6397=m
> >
> > Any opinion on this? Matthias? Anyone else?
>
> CONFIG_RTC_DRV_MT6397=m is already present in defconfig.
> We can also add CONFIG_REGULATOR_DA9211=m to defconfig.

We need add config snippet override for CONFIG_REGULATOR_DA9211=y 
because our CI don't have any initrd with modules, we just immediately 
continue boot from NFS, where we load rest of the boot non-essential 
modules.

For generic kernel, I assume CONFIG_REGULATOR_DA9211=m should be added.

David

> Regards,
> Vignesh

--
David Heidelberg
Consultant Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718

Attachment: OpenPGP_0x69F567861C1EC014.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature