Hi, On Sat, Sep 2, 2023 at 7:42 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: ...<snip> > @@ -952,6 +960,7 @@ static const struct dev_pm_ops mtk_drm_pm_ops = { > static struct platform_driver mtk_drm_platform_driver = { > .probe = mtk_drm_probe, > .remove = mtk_drm_remove, I think this patch, and perhaps some others in this series, will have a trivial conflict to Uwe's work about the remove callback conversion e.g. [1], so you might want to rebase the series onto the latest linux-next. On the other hand, I tested this patch on MT8195 and MT8188 Chromebooks and I don't see issues during boot / reboot, so Reviewed-by: Fei Shao <fshao@xxxxxxxxxxxx> Tested-by: Fei Shao <fshao@xxxxxxxxxxxx> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/?h=mediatek-drm-next&id=b3af12a0b46888340e024ba8b231605bcf2d0ab3 > + .shutdown = mtk_drm_shutdown, > .driver = { > .name = "mediatek-drm", > .pm = &mtk_drm_pm_ops, > -- > 2.42.0.283.g2d96d420d3-goog > >